[FEATURE][86dr2w52q] Weird behaviour on loading forms of Jotforms #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* RadioGroup error using forwardRef when isn't necessary * Make Jotform iframe as component and adding a loading to prevent weird behavios while jotform load the form * fix jotform undefined variable * add package.lock file pending * new color for tailwind
| key={id} | ||
| label={label} | ||
| name={uniqueName} | ||
| checked={value === undefined ? value : value === id} |
There was a problem hiding this comment.
If value is undefined, then we use value? 👀
There was a problem hiding this comment.
this component was copied and pasted from another project, it's not used in this project ( for now ), the unique reason to edit was to fix an error on the console.
cgarcia-lightit
requested review from
sgoycoechea-lightit and
lucaslightit
and removed request for
sgoycoechea-lightit and
lucaslightit
sgoycoechea-lightit
approved these changes
Jan 17, 2024
sgoycoechea-lightit
deleted the
feature/86dr2w52q/add-loading-for-jotforms-iframes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Light It Pull Request Template ⚡⚡⚡
Resolve: 86dr2w52q
Description
feature: resolve the following problems
Proof of Test (optional) 📷
With loading
Seniors.profiling.with.loading.mov
Cancer.profiling.with.loading.mov
Without loading
Cancer.profiling.without.loading.mov
Seniors.profiling.without.loading.mov
Checklist ✅