Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CU-86dv570a1] memorial sloan kettering cancer center referral #241

Conversation

gianfranco-rocco
Copy link
Contributor

@gianfranco-rocco gianfranco-rocco commented Nov 20, 2024

⚡ Add Memorial Sloan Kettering Cancer Center to referral partners in Jotform + admin - CU-86dv570a1

💻 What type of change is this?

  • 💎 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Styling
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build / CI

⭐ Description

Added "Memorial Sloan Kettering Cancer Center" to referrals.

For more background, see ticket CU-86dv570a1.

✅ Checklist

To review

  • I have tested this change locally in multiple screen sizes
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If my task include an endpoint, I add the endpoint to Hopscotch/Postman Project
  • Any dependent changes have been merged and published in downstream modules

@martinopp
Copy link

@github-actions github-actions bot changed the title Feature/cu 86dv570a1/memorial sloan kettering cancer center referral [CU-86dv570a1] memorial sloan kettering cancer center referral Nov 20, 2024
@gianfranco-rocco
Copy link
Contributor Author

@@ -202,6 +203,8 @@ export const AccountCreation = () => {
return "18";
case Flows.private_health_management:
return "19";
case Flows.memorial_sloan_kettering_cancer_center:
return "20";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it falls out of the scope but doesn't it make sense to use some js to avoid human error and use the object order?

sth like this:

const getIndex = (input: FlowType) => `${Object.values(allData).findIndex(input)}`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'd make sense, yes! @sgoycoechea-lightit want me to refactor this in this PR?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets create a task for it and leave it in the todo of this sprint, since we need to tackle other priorities now

cspell.json Outdated
Comment on lines 62 to 65
"Zuko",
"ZUKO",
"zustand"
"zustand",
"Schar"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My experience with cspell tells me that 'Zuko' and 'ZUKO' can both be addressed with lowercase 'zuko', same would go with 'Schar' (if entered to the json in lowercase, all cases are matched). but i could not find supporting documentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try having only 'zuko' and see if that works.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to commit with just 'zuko' but I'm not sure if that means 'zuko' does do the trick lol.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in that clase, replace the new word Schar with its lowercase counterpart :)

@gianfranco-rocco gianfranco-rocco merged commit 0ffd4ac into develop Nov 21, 2024
1 check passed
@gianfranco-rocco gianfranco-rocco deleted the feature/CU-86dv570a1/memorial-sloan-kettering-cancer-center-referral branch November 21, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants