-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CU-86dv570a1] memorial sloan kettering cancer center referral #241
[CU-86dv570a1] memorial sloan kettering cancer center referral #241
Conversation
@@ -202,6 +203,8 @@ export const AccountCreation = () => { | |||
return "18"; | |||
case Flows.private_health_management: | |||
return "19"; | |||
case Flows.memorial_sloan_kettering_cancer_center: | |||
return "20"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it falls out of the scope but doesn't it make sense to use some js to avoid human error and use the object order?
sth like this:
const getIndex = (input: FlowType) => `${Object.values(allData).findIndex(input)}`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That'd make sense, yes! @sgoycoechea-lightit want me to refactor this in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets create a task for it and leave it in the todo of this sprint, since we need to tackle other priorities now
cspell.json
Outdated
"Zuko", | ||
"ZUKO", | ||
"zustand" | ||
"zustand", | ||
"Schar" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My experience with cspell tells me that 'Zuko' and 'ZUKO' can both be addressed with lowercase 'zuko', same would go with 'Schar' (if entered to the json in lowercase, all cases are matched). but i could not find supporting documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can try having only 'zuko' and see if that works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let me know!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to commit with just 'zuko' but I'm not sure if that means 'zuko' does do the trick lol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in that clase, replace the new word Schar with its lowercase counterpart :)
Testing if lowercase covers both.
⚡ Add Memorial Sloan Kettering Cancer Center to referral partners in Jotform + admin - CU-86dv570a1 ⚡
💻 What type of change is this?
⭐ Description
Added "Memorial Sloan Kettering Cancer Center" to referrals.
For more background, see ticket CU-86dv570a1.
✅ Checklist
To review