Feature/added action to deploy webapp to s3 #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| aws-region: us-east-2 | ||
|
|
||
| - name: Deploy static site to S3 bucket | ||
| run: aws s3 sync ./dist/ s3://eo-care-web-prod --delete |
There was a problem hiding this comment.
What is --delete for? Maybe it would be good to keep old versions for rollbacks?
Although I guess we could revert in github and redeploy.
There was a problem hiding this comment.
--delete deletes all the previous files not present in the new version. I prefer to do it to avoid collisions. If we have to roll back, we can do it by reverting the PR.
sgoycoechea-lightit
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡ Add action to deploy web to s3 ⚡
💻 What type of change is this?
I configured two new actions to deploy eo-web to a specific bucket. So we can access the built version of the site directly from S3 and not from Github