Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C org thank you pages #102

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

sgoycoechea-lightit
Copy link
Collaborator

C org thank you pages ⚡⚡⚡

Resolve: closes 86drt5n32

Description and Requires ⭐

Updated the faqs for the c-org, cancer support community, twist out cancer, and cancer resource center thank you pages.

Checklist ✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@martinopp
Copy link

@@ -48,6 +49,11 @@ export const CancerSurveyThankYou = () => {

useMount(() => mutate({ email, phase, submission_id }));

const flowsWithCOrgFaqs = ["c_org", "twist_out_cancer", "resource_center_1", "resource_center_2"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to pass the flow and usePayment variables to ≤FAQs /> Component to avoid duplicating the logic.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought of that but didn't do it because I don't think the FAQs component should know about flows or payments, and wanted to make it as dumb as possible.

But I guess both approaches have their advantages.

@sgoycoechea-lightit sgoycoechea-lightit merged commit c2f4ebc into develop Mar 5, 2024
1 check passed
@cgarcia-lightit cgarcia-lightit deleted the feature/CU-86drt5n32/c-org-thank-you branch March 13, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants