Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved SAML instructions #456

Merged
merged 10 commits into from
Dec 9, 2024
Merged

Conversation

cgutteridge
Copy link

Hi, I've been working through the SAML instructions and I've just got it working with Azure (yay). I found the instructions quite hard to read so I've changed the layout and made some changes and additions based on my experience following them.

I can't see how to make a Pull Request to the wiki so I'm submitting it like this, but if you like the changes you might want to put them into the wiki rather than approve this pull request.

Copy link
Contributor

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

I can't really review as I have never setup SAML. But I did read it and it seems to make sense.

The only thing I would suggest it to squash it down to one commit.

@effgarces effgarces merged commit 502829f into LibreBooking:develop Dec 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants