Fix Facebook login, smarty upgrade, Fix error on reservation page, when accessory is NULL on max or min. #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure that NULL values in both MinQuantity and MaxQuantity do not trigger errors during validation, we can update the MaxQuantity check in the same way as the MinQuantity check. I've added a check for is_null for both limits in the updated code.
Smarty works fine in 4.5
Package facebook/graph-sdk is abandoned, you should avoid using it. No replacement was suggested. This is an unofficial version of Facebook's PHP SDK designed for PHP 7/8+. It is being maintained and tested against the newest PHP versions. You can use this in place of version 5.x of Facebook's deprecated facebook/graph-sdk package.
|
Thanks for the PR, can you please take a look at the failed test and see what is causing the issue with these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure that NULL values in both MinQuantity and MaxQuantity do not trigger errors during validation, we can update the MaxQuantity check in the same way as the MinQuantity check.
I've added a check for is_null for both limits in the updated code.
Smarty works fine in 4.5
Package facebook/graph-sdk is abandoned, you should avoid using it. No replacement was suggested.
This is an unofficial version of Facebook's PHP SDK designed for PHP 7/8+. It is being maintained and tested against the newest PHP versions. You can use this in place of version 5.x of Facebook's deprecated facebook/graph-sdk package.