Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ldap_close with boolean parameter #380

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix: ldap_close with boolean parameter #380

merged 1 commit into from
Jul 9, 2024

Conversation

oxconan
Copy link

@oxconan oxconan commented Jul 1, 2024 •
edited
Loading

  • When destruct object, this function will be called, we will get issue if this->_link is False value
Error: TypeError: ldap_close(): Argument #1 ($ldap) must be of type LDAP\\Connection, false given in plugins/Authentication/Ldap/LDAP2.php
  • Fix warning userGroups un-init value if loadGroups is False
PHP Warning:  Undefined variable $userGroups in plugins/Authentication/Ldap/Ldap2Wrapper.php

JohnVillalovos
JohnVillalovos approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@effgarces effgarces merged commit 0ed3a3b into LibreBooking:develop Jul 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnVillalovos JohnVillalovos JohnVillalovos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oxconan @JohnVillalovos @effgarces @thcao-ampere