Merge pull request #354 from JohnVillalovos/jlvillal/issue_242

fix: declare `ReservationControllerResult.requiresApproval`
LibreBooking · May 27, 2024 · a27ce5b · a27ce5b
2 parents 5b557b9 + 1545a7b
commit a27ce5b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/WebServices/AuthenticationWebService.php b/WebServices/AuthenticationWebService.php
@@ -6,8 +6,21 @@
 require_once(ROOT_DIR . 'WebServices/Requests/AuthenticationRequest.php');
 require_once(ROOT_DIR . 'WebServices/Requests/SignOutRequest.php');
 
+class SignedOutResponse extends RestResponse
+{
+    /**
+     * @var bool;
+     */
+    public $signedOut;
+}
+
+
 class AuthenticationWebService
 {
+    /**
+     * @var IRestServer
+     */
+    private $server;
     /**
      * @var IWebServiceAuthentication
      */
@@ -71,7 +84,7 @@ public function SignOut()
         Log::Debug('WebService SignOut for userId %s and sessionToken %s', $userId, $sessionToken);
 
         $this->authentication->Logout($userId, $sessionToken);
-        $r = new RestResponse();
+        $r = new SignedOutResponse();
         $r->signedOut = true;
         $this->server->WriteResponse($r);
     }

diff --git a/WebServices/Controllers/ReservationSaveController.php b/WebServices/Controllers/ReservationSaveController.php
@@ -288,6 +288,10 @@ class ReservationControllerResult
      * @var array|string[]
      */
     private $errors = [];
+    /**
+     * @var bool
+     */
+    private $requiresApproval;
 
     public function __construct($referenceNumber = null, $errors = [], $requiresApproval = false)
     {