Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.7/3.8 support; add Python 3.12 & packaging fixes #149

Merged
merged 11 commits into from
Feb 29, 2024

Conversation

sk1p
Copy link
Member

@sk1p sk1p commented Feb 28, 2024

Sibling of LiberTEM/LiberTEM#1607

Also use tox-uv for installing packages in CI

Contributor Checklist:

  • I have added or updated my entry in the creators.json file
  • I have added a changelog entry for my contribution
  • I have added/updated documentation for all user-facing changes
  • I have added/updated test cases

Reviewer Checklist:

  • /azp run libertem.libertem-live-data passed

Sibling of LiberTEM/LiberTEM#1607

Also use tox-uv for installing packages in CI
@sk1p sk1p added the infra CI/CD infrastructure etc. label Feb 28, 2024
@sk1p sk1p added this to the 0.3 milestone Feb 28, 2024
@sk1p
Copy link
Member Author

sk1p commented Feb 28, 2024

/azp run libertem.libertem-live-data

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.75%. Comparing base (37f1ea7) to head (4dc3ec2).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage   79.56%   79.75%   +0.18%     
==========================================
  Files          35       35              
  Lines        3441     3442       +1     
  Branches      581      581              
==========================================
+ Hits         2738     2745       +7     
+ Misses        565      560       -5     
+ Partials      138      137       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sk1p
Copy link
Member Author

sk1p commented Feb 28, 2024

/azp run libertem.libertem-live-data

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sk1p
Copy link
Member Author

sk1p commented Feb 28, 2024

/azp run libertem.libertem-live-data

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sk1p
Copy link
Member Author

sk1p commented Feb 28, 2024

tox-uv failures are due to our sdist name being completely wrong. Citing from https://packaging.python.org/en/latest/specifications/binary-distribution-format/#escaping-and-unicode, which is referenced from https://peps.python.org/pep-0625/#specification:

As the components of the filename are separated by a dash (-, HYPHEN-MINUS), this character cannot appear within any component. [..]

The issue can be reproduced by running python -m build --sdist in the LiberTEM-live source tree.

Next step would be finding out why this is the case, how that name is generated, if we are at fault or if this is an upstream bug (setuptools?) etc.

@sk1p
Copy link
Member Author

sk1p commented Feb 29, 2024

/azp run libertem.libertem-live-data

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sk1p sk1p changed the title Drop Python 3.7/3.8 support; add Python 3.12 Drop Python 3.7/3.8 support; add Python 3.12 & packaging fixes Feb 29, 2024
@sk1p
Copy link
Member Author

sk1p commented Feb 29, 2024

/azp run libertem.libertem-live-data

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sk1p
Copy link
Member Author

sk1p commented Feb 29, 2024

/azp run libertem.libertem-live-data

Copy link

Azure Pipelines failed to run 1 pipeline(s).

@sk1p
Copy link
Member Author

sk1p commented Feb 29, 2024

/azp run libertem.libertem-live-data

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Don't hardcode bin path inside the tox env (should be on the PATH), also
check early if the process died for some reason.
@sk1p
Copy link
Member Author

sk1p commented Feb 29, 2024

/azp run libertem.libertem-live-data

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sk1p sk1p merged commit 31e2392 into LiberTEM:master Feb 29, 2024
31 checks passed
@sk1p sk1p deleted the drop-py37-py38-add-py312 branch February 29, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra CI/CD infrastructure etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant