Descan corrected picker #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the use of a corrected picker in LiberTEM (https://github.com/LiberTEM/LiberTEM/pull/1635) with LiberTEM-live-server, which is useful to compensate for descan effects in the sample, enabling quick examination of whether the sample signal is from descan or any other effects, in particular STEM-DPC.
Upon startup it loads a file, performs centre-of-mass processing, and uses that to create a corrected picker that shifts the probe by the descan and displays it.
The status of the PR is that it has a lot of ad-hoc code specific to the new UDF. It is desirable then to refactor it into more generic routines that can support many potential UDFs in the future. In particular, ones that need communication between the server and the plugin. This will be a focus for me on the way forwards.