Use one-way binding for the path property (web-platform-tests#3342)

* Use one-way binding for the path property * Address review feedback
LeonardYam · Jun 6, 2023 · 28f7f6a · 28f7f6a
1 parent 24f02dc
commit 28f7f6a
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/webapp/components/path.js b/webapp/components/path.js
@@ -15,7 +15,6 @@ const PathInfo = (superClass) => class extends superClass {
     return {
       path: {
         type: String,
-        notify: true,
       },
       encodedPath: {
         type: String,

diff --git a/webapp/views/wpt-app.js b/webapp/views/wpt-app.js
@@ -153,7 +153,7 @@ class WPTApp extends PathInfo(WPTFlags(TestRunsUIBase)) {
         <wpt-results name="results"
                      is-loading="{{resultsLoading}}"
                      structured-search="[[structuredSearch]]"
-                     path="{{subroute.path}}"
+                     path="[[subroute.path]]"
                      test-runs="[[testRuns]]"
                      test-paths="{{testPaths}}"
                      search-results="{{searchResults}}"

diff --git a/webapp/views/wpt-results.js b/webapp/views/wpt-results.js
@@ -296,7 +296,7 @@ class WPTResults extends AmendMetadataMixin(Pluralizer(WPTColors(WPTFlags(PathIn
                 <td onclick="[[handleTriageSelect(null, node, testRun)]]" onmouseover="[[handleTriageHover(null, node, testRun)]]">
                   <path-part
                       prefix="/results"
-                      path="{{ node.path }}"
+                      path="[[ node.path ]]"
                       query="{{ query }}"
                       is-dir="{{ node.isDir }}"
                       is-triage-mode=[[isTriageMode]]>