Feature/#413 time picker does not accept inline editing #478
Conversation
uploading fix to production table
minor font fix dev to main
| }; | ||
|
|
||
| export const setTime = (csvData: string[]) => { | ||
| let [hora, minutos] = csvData; |
There was a problem hiding this comment.
Can you name the varables in english ;)
| hora > '23' || | ||
| minutos.length !== 2 || | ||
| minutos === '' || | ||
| minutos > '59' |
There was a problem hiding this comment.
Avoid magic numbers in code, creat on top of the file, something like:
const MAX_DIGITS = 2;
const MAX_HOURS= '23';
const MAX_MINUTES = '59'
| if (csvData.length < 2) { | ||
| return true; | ||
| } | ||
| if (csvData[0] !== 'hh' || csvData[1] !== 'mm') { |
There was a problem hiding this comment.
Same here
const HOUR_MASK = 'hh';
const MINUTES_MASK='mm';
| clockIcon.src = clockIconSrc; | ||
|
|
||
| return ( | ||
| <Group {...commonGroupProps} {...shapeProps}> |
There was a problem hiding this comment.
@deletidev can you check if we have alreaday some const values to apply?
There was a problem hiding this comment.
On svg, the font family need to be change to font-family="Comic Sans MS, Balsamiq Sans, cursive", .
Here on all Text, fontFamily={INPUT_SHAPE.DEFAULT_FONT_FAMILY}, you may need to update spacing,
strokeWidth={INPUT_SHAPE.DEFAULT_STROKE_WIDTH}, and it is posible, control the size like on the existing input:
Take a look to the input-shape.tsx.
brauliodiez
deleted the
feature/#413-Time-Picker-does-not-accept-inline-editing
branch
No description provided.