Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/#149 Create a Post it Shape as konva Component under BASIC SHAPES #176

Merged
merged 9 commits into from
Aug 14, 2024
Merged

feature/#149 Create a Post it Shape as konva Component under BASIC SHAPES #176

merged 9 commits into from
Aug 14, 2024

Conversation

IonutGabi
Copy link
Collaborator

  • Created Post it SVG
  • Created Post it Shape
  • Added Post it type in src/core/index.ts
  • Created Post it in mockBasicShapesCollection
  • Created the function renderPostit and added case in src/pods/canvas/shape-renderer/simple-basic-shapes/postit.rerender.tsx file
  • Added the case "postit" in src/pods/canvas/shape-renderer/simple-basic-shapes/index.ts

Close #149

@IonutGabi IonutGabi requested a review from brauliodiez August 12, 2024 11:43
brauliodiez
brauliodiez reviewed Aug 12, 2024
View reviewed changes
src/common/components/front-basic-sapes/postit-basic-shape.tsx
export const getPostItShapeSizeRestrictions = (): ShapeSizeRestrictions =>
postItShapeRestrictions;

export const PostItShape = forwardRef<any, ShapeProps>(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you try to resize the post it container (just using the transformer, and dragging with the mouse) it won't resize well, can you check this with @antonio06 ?

@brauliodiez brauliodiez merged commit d35e7c6 into main Aug 14, 2024
1 check passed
@brauliodiez brauliodiez deleted the feature/#149-Create-a-Post-it-Shape-as-konva-Component-under-BASIC-SHAPES branch August 14, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brauliodiez brauliodiez brauliodiez left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a Post it Shape as konva Component under BASIC SHAPES
2 participants
@IonutGabi @brauliodiez