Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding keydown listener for Escape key to cancel edit mode #103

Merged
merged 2 commits into from
Aug 4, 2024

Conversation

LourdesRsdp
Copy link
Collaborator

  • Enhanced useEffect to include a keydown event listener
  • Cancel edit mode and do not submit text when Escape key is pressed
  • Ensure proper cleanup of event listeners

closed #92

- Enhanced useEffect to include a keydown event listener
- Cancel edit mode and do not submit text when Escape key is pressed
- Ensure proper cleanup of event listeners
# Conflicts:
#	src/common/components/inline-edit/inline-edit.tsx
@LourdesRsdp LourdesRsdp requested review from oleojake and removed request for oleojake August 3, 2024 19:09
@brauliodiez brauliodiez merged commit 9702a7c into main Aug 4, 2024
1 check passed
@brauliodiez brauliodiez deleted the feature/#92-inline-edit-esc-key branch August 4, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline Edit Esc Key should cancel the edition
2 participants