[coverage](pipeline) Remove unless code and add call method for cover…

…age (apache#25552) Remove unless code and add call method for coverage
LemonLiTree · Oct 23, 2023 · 5cb5121 · 5cb5121
1 parent b845281
commit 5cb5121
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 7 deletions.
diff --git a/be/src/pipeline/exec/exchange_sink_operator.h b/be/src/pipeline/exec/exchange_sink_operator.h
@@ -57,8 +57,6 @@ class ExchangeSinkOperator final : public DataSinkOperator<ExchangeSinkOperatorB
 
     Status close(RuntimeState* state) override;
 
-    RuntimeState* state() { return _state; }
-
 private:
     std::unique_ptr<ExchangeSinkBuffer<vectorized::VDataStreamSender>> _sink_buffer;
     int _dest_node_id = -1;

diff --git a/be/src/pipeline/exec/multi_cast_data_stream_sink.h b/be/src/pipeline/exec/multi_cast_data_stream_sink.h
@@ -38,7 +38,7 @@ class MultiCastDataStreamSinkOperator final
     MultiCastDataStreamSinkOperator(OperatorBuilderBase* operator_builder, DataSink* sink)
             : DataSinkOperator(operator_builder, sink) {}
 
-    bool can_write() override { return true; }
+    bool can_write() override { return _sink->can_write(); }
 };
 
 class MultiCastDataStreamSinkOperatorX;

diff --git a/be/src/util/proto_util.h b/be/src/util/proto_util.h
@@ -45,9 +45,7 @@ Status request_embed_attachment_contain_block(Params* brpc_request, Closure* clo
     return st;
 }
 
-inline bool enable_http_send_block(
-        const PTransmitDataParams& request,
-        bool transfer_large_data_by_brpc = config::transfer_large_data_by_brpc) {
+inline bool enable_http_send_block(const PTransmitDataParams& request) {
     if (!config::transfer_large_data_by_brpc) {
         return false;
     }

diff --git a/be/src/vec/sink/vdata_stream_sender.cpp b/be/src/vec/sink/vdata_stream_sender.cpp
@@ -207,7 +207,7 @@ Status Channel<Parent>::send_remote_block(PBlock* block, bool eos, Status exec_s
 
     {
         SCOPED_SWITCH_THREAD_MEM_TRACKER_LIMITER(ExecEnv::GetInstance()->orphan_mem_tracker());
-        if (enable_http_send_block(_brpc_request, config::transfer_large_data_by_brpc)) {
+        if (enable_http_send_block(_brpc_request)) {
             RETURN_IF_ERROR(transmit_block_http(_state->exec_env(), _closure, _brpc_request,
                                                 _brpc_dest_addr));
         } else {