Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce parallelism of at most 4 for match games to reduce short game bias. #72

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Tilps
Copy link
Contributor

@Tilps Tilps commented Jan 1, 2019

No description provided.

@Tilps
Copy link
Contributor Author

Tilps commented Jan 1, 2019

I realized that people with high parallelism would end up with a significant level of short game bias in their match game uploads, which could become quite significant as more people contribute and the match games last for only a minute or so. High level of parallelism shouldn't be needed to get 100% gpu usage from match games, so going to try 2 which ensures no bias due to alternating colors and the server specifying which of flipped or not flipped we have to upload.

@Tilps
Copy link
Contributor Author

Tilps commented Jan 1, 2019

On second thoughts parallelism of 2 does not eliminate bias.

But there is inherent bias in our distributed system that is almost equivalent anyway. But letting users set super high parallelism is probably not a good idea for match games anyway - so I think this PR is probably fine to go in. With a revised comment which I've added.

@Tilps Tilps requested a review from borg323 January 1, 2019 00:51
@Tilps Tilps changed the title Enforce parallelism of 2 for match games to avoid short game bias. Enforce parallelism of 2 for match games to reduce short game bias. Jan 1, 2019
@Tilps Tilps changed the title Enforce parallelism of 2 for match games to reduce short game bias. Enforce parallelism of at most 4 for match games to reduce short game bias. Jan 1, 2019
@Tilps
Copy link
Contributor Author

Tilps commented Jan 1, 2019

After a bit of performance testing, 2 might be a significant slow down compared to 16, so I'm going to allow up to 4.
I also made it respect the users parallelism setting if its lower than 4, for low end contributors. (Although they should probably just not do match games.)

@Tilps
Copy link
Contributor Author

Tilps commented Jan 27, 2019

I've decided this probably isn't needed, but I'll probably keep it around just in case I change my mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant