Fix web3-subprovider to return subprovider (no longer async)

LedgerHQ · Feb 16, 2018 · 83d8423 · 83d8423
1 parent b53fa01
commit 83d8423
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/packages/create-dapp/template/package.json b/packages/create-dapp/template/package.json
@@ -8,7 +8,7 @@
     "react-scripts": "1.1.0",
     "truffle-contract": "^3.0.3",
     "prop-types": "^15.2.0",
-    "@ledgerhq/web3-subprovider": "^4.0.0",
+    "@ledgerhq/web3-subprovider": "^4.1.0",
     "@ledgerhq/hw-transport-u2f": "^4.0.0",
     "web3": "^1.0.0-beta.29"
   },

diff --git a/packages/create-dapp/template/src/wallets.js b/packages/create-dapp/template/src/wallets.js
@@ -20,10 +20,10 @@ export default [
   {
     name: "Ledger device",
     // create a web3 with the ledger device
-    getWeb3: async () => {
+    getWeb3: () => {
       const engine = new ProviderEngine();
       const getTransport = () => TransportU2F.create();
-      const ledger = await createLedgerSubprovider(getTransport, {
+      const ledger = createLedgerSubprovider(getTransport, {
         networkId,
         accountsLength: 5
       });

diff --git a/packages/web3-subprovider/src/index.js b/packages/web3-subprovider/src/index.js
@@ -69,7 +69,7 @@ engine.addProvider(new RpcSubprovider({ rpcUrl }));
 engine.start();
 const web3 = new Web3(engine);
  */
-export default async function createLedgerSubprovider(
+export default function createLedgerSubprovider(
   getTransport: () => Transport<*>,
   options?: SubproviderOptions
 ): HookedWalletSubprovider {
@@ -191,5 +191,6 @@ export default async function createLedgerSubprovider(
         .catch(err => callback(err, null));
     }
   });
+
   return subprovider;
 }