Update XRP app flags #299
Merged
Update XRP app flags #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app flags were incorrectly set on the app-xrp. This PR updates the app flags to reflect the corrected flags in the app-xrp.
The following flag was commented out in the app-xrp Makefile.
#HAVE_APPLICATION_FLAG_GLOBAL_PIN = 1The PR in the app-xrp is here. You can see the failed workflow here.
This is the last task todo on a security audit so I really appreciate you taking a look at this. The security audit team has already reached out to Ledger to confirm this flag should be removed.
Thank You