-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DSDK 175] Add LedgerHQ UI library #8
Conversation
@aussedatlo is attempting to deploy a commit to the LedgerHQ Team on Vercel. To accomplish this, @aussedatlo needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
51a28f6
to
794fb71
Compare
import { GlobalStyle } from "@/components/globalstyles"; | ||
import type { AppProps } from "next/app"; | ||
|
||
export default function App({ Component, pageProps }: AppProps) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we only use naming exports ?
An eslint rule could be useful for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this file, next require a default import. But I agree we should use naming exports when possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use only named exports @jdabbech-ledger ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Named exports are more restrictive as they require you to use a specific identifier when importing. Default exports are more flexible, you can use any name during import but may lead to inconsistencies in the codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @aussedatlo on this point, moreover the IDEs follow more easily the import with naming exports in general
794fb71
to
92eea72
Compare
* used to customize the rendering of pages. For more information, refer to the Next.js | ||
* documentation on customizing the App component: | ||
* https://nextjs.org/docs/advanced-features/custom-app | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you for the added doc ;)
e656c39
to
3b24209
Compare
3b24209
to
aa845e1
Compare
π Description
Adding the Ledger LDD Design System to the sample app, remove tailwindcss and configure styled-component.
Inspired by next.js styled component example
β Context
β Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.
npx changeset
was attached.[ ] Impact of the changes:
π§ Checklist for the PR Reviewers