Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (signer-btc) [DSDK-485]: Implement getWalletAddress task #567

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

fAnselmi-Ledger
Copy link
Contributor

@fAnselmi-Ledger fAnselmi-Ledger commented Dec 18, 2024

πŸ“ Description

Implement getWalletAddress task

❓ Context

βœ… Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Dec 18, 2024 2:21pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
doc-device-management-kit ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 2:21pm

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Messages
βœ… Danger: All checks passed successfully! πŸŽ‰

Generated by 🚫 dangerJS against 87fea6a

@fAnselmi-Ledger fAnselmi-Ledger force-pushed the feat/DSDK-485-ts-signer-implement-get-wallet-address-task branch from cc92710 to 87fea6a Compare December 18, 2024 14:19
@fAnselmi-Ledger fAnselmi-Ledger marked this pull request as ready for review December 19, 2024 08:38
@fAnselmi-Ledger fAnselmi-Ledger requested a review from a team as a code owner December 19, 2024 08:38
import { DataStore } from "@internal/data-store/model/DataStore";
import { Sha256HasherService } from "@internal/merkle-tree/service/Sha256HasherService";
import { CommandUtils } from "@internal/utils/CommandUtils";
import { CommandUtils as BtcCommandUtils } from "@internal/utils/CommandUtils";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same object to the one in previous line, isn't it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants