Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”– (chore) [NO-ISSUE]: Backmerge #554

Closed
wants to merge 5 commits into from
Closed

Conversation

jdabbech-ledger
Copy link
Contributor

πŸ“ Description

Backmerge of main in develop
Set private: true in every package

❓ Context

  • JIRA or GitHub link:
  • Feature:

βœ… Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@jdabbech-ledger jdabbech-ledger requested a review from a team as a code owner December 11, 2024 14:00
Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Dec 11, 2024 2:00pm
doc-device-management-kit ❌ Failed (Inspect) Dec 11, 2024 2:00pm

Copy link
Contributor

Fails
🚫

Please fix the PR branch name to match the convention, see CONTRIBUTING.md.

Wrong branch name: main

ℹ️ Regex to match: /^(feature|feat|bugfix|bug|hotfix|fix|support|chore|core|doc|refacto|refactor)\/((dsdk)-[0-9]+|no-issue|issue-[0-9]+)-.+/i

  • Rules:
    • Must start with a type (feature, feat, bugfix, bug, hotfix, fix, support, chore, core, doc, refacto, refactor)
    • Followed by a SLASH ("/")
    • Followed by a JIRA issue number (DSDK-1234) or "no-issue" or "issue-1234" if fixing a Github issue
    • Followed by a DASH ("-")
    • Followed by a description

ℹ️ Example: feat/dsdk-1234-my-feature

🚫

One or more commit message does not match the convention, see CONTRIBUTING.md.

Wrong commit messages:
β€’ πŸ”– (release) [NO-ISSUE]: Versioning packages (#552)
β€’ πŸ”– (eth) [NO-ISSUE]: Signer Eth v1.1.1 + Context module v1.1.0 (#553)

ℹ️ Regex to match: /^.+\(([a-z]+\-?){1,}\): [A-Z].*/

  • Rules:
    • Must start with a word (usually an emoji)
    • Followed by a SPACE
    • Followed by a scope in parentheses and in LOWERCASE
    • Followed by a colon (":") and a SPACE
    • Followed by a Capitalized message

Example: πŸ’š (scope): My feature

Generated by 🚫 dangerJS against 2cbe039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant