Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (signer-near) [NO-ISSUE]: Near signer #536

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

jazalizil
Copy link

@jazalizil jazalizil commented Dec 3, 2024

πŸ“ Description

Near signer state of art

  • GetPublicKey
  • GetWalletId
  • GetVersion
  • SignTransaction
  • SignMessage (NEP413)
  • SignDelegateAction (NEP366)

WIP implementation in https://github.com/near/wallet-selector/tree/main/packages/ledger: https://github.com/jazalizil/device-sdk-ts/tree/feat/near-wallet

❓ Context

  • JIRA or GitHub link:
  • Feature: Create near signer

βœ… Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@jazalizil jazalizil requested a review from a team as a code owner December 3, 2024 14:00
Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Dec 11, 2024 9:06am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
doc-device-management-kit ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2024 9:06am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant