Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSDK 146] Setup bundler - build system for monorepo #3

Conversation

jdabbech-ledger
Copy link
Contributor

@jdabbech-ledger jdabbech-ledger commented Dec 18, 2023

πŸ“ Description

Make it build

❓ Context

βœ… Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • setup eslint with custom config
    • eject sample app
    • build & dev ok
    • lint ok

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@jdabbech-ledger jdabbech-ledger changed the base branch from main to feature/DSDK-80-setup-file-structure December 18, 2023 15:43
@jdabbech-ledger jdabbech-ledger force-pushed the feat/DSDK-146-build-system branch 6 times, most recently from f6f4c89 to 792254f Compare December 19, 2023 10:50
@jdabbech-ledger jdabbech-ledger force-pushed the feat/DSDK-146-build-system branch 3 times, most recently from 2e23f01 to d719dc7 Compare December 19, 2023 14:29
@jdabbech-ledger jdabbech-ledger force-pushed the feat/DSDK-146-build-system branch from d719dc7 to faec549 Compare December 19, 2023 14:48
@jdabbech-ledger jdabbech-ledger merged commit 66ce8b6 into feature/DSDK-80-setup-file-structure Dec 19, 2023
1 check passed
@jdabbech-ledger jdabbech-ledger deleted the feat/DSDK-146-build-system branch December 19, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant