Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
I've been going around, trying
semantic-release
but it's definitely not made with monorepo in mind. There is no internal package dependencies update and overall is a pain to make it work in a monorepo.So back to our loyal
changesets
tool. It follows the same convention as Ledger Live. Whenever we make a change that impact userland, we should provide a changeset with a description of the change as well as the severity of our change.I've also setup the official changesets/action right now, but only for the creation of the versioning PR. Basically what it does, whenever we merge on develop, if there is a new changeset, it will be applied to an
evergreen
branch and thechangeset version
will be applied, keeping an updated version of each package.Whenever we want to make a release, we should merge this branch then use
changeset publish
. Thechangesets/action
can also be used to automate the release and publishing tonpm
andgithub release
, however this is outside of the scope of this PR and should be discussed with the team to decide on the wanted workflow.The github action can be removed if it's not fulfilling our expectations or we need a more custom release process.
Example of PR here (the infos are wrong, the branches also, but it's just provided as example)
❓ Context
✅ Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.
pnpm changelog
runschangeset add
pnpm bump
runschangeset version
pnpm release
runschangeset publish
pnpm commitcl
runspnpm changelog && pnpm commit
develop
)🧐 Checklist for the PR Reviewers