-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
β (repo): Add gitmoji [DSDK-188] #24
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
6cd7145
to
77638fc
Compare
So the new convention for PR title is |
Right now i'm testing the CLI to see what it has to offer, but it seems that if we want to keep the ticket in the title we could use it in the @aussedatlo @ofreyssinet-ledger @jdabbech-ledger @jiyuzhuang Possible format
|
add gitmoji dependency and `commit` script from root package.json
77638fc
to
391c0ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM π
Thank you for your work @valpinkman. In my opinion, I prefer the second one, but can we do some adaptions like:
|
Using gitmoji |
exactly this ^ |
DSDK-188 setup git conventions
π Description
Add Gitmoji as our new git conventions
Add a commit script to run from the root folder =>
pnpm commit
β Context
β Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.
π§ Checklist for the PR Reviewers