[DSDK-194][FEAT][CORE] Add Logger service #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
valpinkman
commented
Feb 12, 2024
| "!src/**/*.stub.ts", | ||
| "!src/index.ts", |
There was a problem hiding this comment.
I don't think we particularly want to test those files, but it could be interesting to test that the imports are correctly defined ?
valpinkman
force-pushed
the
feature/dsdk-194-logger-module
branch
from
99a8dda to
b4e5f22
Compare
valpinkman
force-pushed
the
feature/dsdk-194-logger-module
branch
2 times, most recently
from
12ddd6a to
9c5c7af
Compare
valpinkman
force-pushed
the
feature/dsdk-194-logger-module
branch
from
9c5c7af to
c2b475d
Compare
valpinkman
force-pushed
the
feature/dsdk-194-logger-module
branch
from
c2b475d to
6326297
Compare
jdabbech-ledger
requested changes
Feb 13, 2024
valpinkman
force-pushed
the
feature/dsdk-194-logger-module
branch
from
8e629cf to
f039eb4
Compare
jdabbech-ledger
approved these changes
Feb 13, 2024
valpinkman
force-pushed
the
feature/dsdk-194-logger-module
branch
from
f039eb4 to
384f70d
Compare
aussedatlo
reviewed
Feb 13, 2024
packages/core/src/internal/logger/service/DefaultLoggerService.ts
Outdated
Show resolved
Hide resolved
aussedatlo
reviewed
Feb 14, 2024
aussedatlo
approved these changes
Feb 14, 2024
valpinkman
force-pushed
the
feature/dsdk-194-logger-module
branch
from
cf6839b to
43a4745
Compare
valpinkman
force-pushed
the
feature/dsdk-194-logger-module
branch
from
de83371 to
e7f5db8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR brings a basic Logger Service as well as a default implementation of a LoggerSubscriber
The Logger service will be used to display some informations based on a LogLevel.
LoggerSubscribers are passed to the Logger, and can interact with the incoming log object to change it's behavior
Log object contains more than just a message (context for example, could be use to differentiate "transport" message from "error" messages, or even "analytics" etc...)
Also in this PR, a few more tests around the existing, so we get closer to a ready for CI state whenever we want to turn on tests.
❓ Context
✅ Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.
🧐 Checklist for the PR Reviewers