✨ (core) [DSDK-180]: Add new USB discovery module #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alexandremgo
force-pushed
the
feature/DSDK-180-usb-service-discovery-service
branch
from
2a92c6c to
cddbc09
Compare
alexandremgo
force-pushed
the
feature/DSDK-180-usb-service-discovery-service
branch
from
e5caded to
d3bdc5f
Compare
alexandremgo
force-pushed
the
feature/DSDK-180-usb-service-discovery-service
branch
from
b30291b to
80d2f65
Compare
alexandremgo
force-pushed
the
feature/DSDK-180-usb-service-discovery-service
branch
from
80d2f65 to
b4e2019
Compare
alexandremgo
force-pushed
the
feature/DSDK-180-usb-service-discovery-service
branch
from
678b81d to
37e630c
Compare
alexandremgo
force-pushed
the
feature/DSDK-180-usb-service-discovery-service
branch
from
37e630c to
eed5f2e
Compare
alexandremgo
force-pushed
the
feature/DSDK-180-usb-service-discovery-service
branch
from
eed5f2e to
538432d
Compare
alexandremgo
force-pushed
the
feature/DSDK-180-usb-service-discovery-service
branch
from
538432d to
dada1e2
Compare
aussedatlo
reviewed
Feb 8, 2024
aussedatlo
reviewed
Feb 8, 2024
packages/core/src/internal/device-model/data/InMemoryDeviceModelDataSource.test.ts
Outdated
Show resolved
Hide resolved
packages/core/src/internal/discovery/use-case/ConnectUseCase.ts
Outdated
Show resolved
Hide resolved
aussedatlo
force-pushed
the
feature/DSDK-180-usb-service-discovery-service
branch
6 times, most recently
from
18d1fec to
27229f8
Compare
aussedatlo
changed the title
aussedatlo
force-pushed
the
feature/DSDK-180-usb-service-discovery-service
branch
from
27229f8 to
bf597d8
Compare
valpinkman
approved these changes
Feb 21, 2024
aussedatlo
changed the title
To demonstrate that once a device of model/productId A is granted access, any other model/productId A device is also granted access, even if plugged in another USB port.
It was making it mandatory to list all added types packages, which was not practical and causing issues with @types/w3c-web-hid
- in usb: UsbHidTransport and its WebHid implementation - in device-model: DeviceModelDataSource and its in-memory implementation - discovery: start and stop discovery uses cases, and connect use case
avoid lint errors in sample when using core imports
aussedatlo
force-pushed
the
feature/DSDK-180-usb-service-discovery-service
branch
from
c3ed33e to
5b4e22b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
First implementation of the
usb,device-modelanddiscoverymodules 🦖.Details
New
usbmodule:UsbHidTransportdefinition (like a data-source)WebUsbHidTransportWebHid implementationNew
device-modelmodule:DeviceModelDataSourcedefinitionInMemoryDeviceModelDataSourceimplementationNew
discoverymodulesPS: some unit-tests are missing, sorry i don't think i will have the time to add them.
PS 2: i forgot to move the errors definitions in their own file, sorry
Also added in the sample app a simple demo: start discovery, connect to device with a get-version apdu exchange in bonus
And finally, i updated
pocs/web-hid-api/to add a new example of WebHid apigetDevicesand to demonstrate that once a device of model/productId A is granted access, any other model/productId A device is also granted access, even if plugged in another USB port.🔥 Web HID POC device SDK demo 🔥
WebHID_DeviceSDK_NanoSP_NanoX.mp4
❓ Context
✅ Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.
[ ] Impact of the changes:
🧐 Checklist for the PR Reviewers