Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSDK-185] [TS] [SDK] Add scaffolding tool to repo #14

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

valpinkman
Copy link
Member

@valpinkman valpinkman commented Jan 29, 2024

📝 Description

To strengthen our DX, I have added hygen, a scaffolding tool, to our repo. It will help make template of reusable structure we can use in our projects. Right now it is scoped to the core project, however any project can use the _template folder to have it's own generators (good for scoping)

❓ Context

✅ Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • Covered by automatic tests.
  • Impact of the changes:
    • added a new script module:create that will scaffold a module and it's files

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 3:58pm

Copy link
Member

@mbertin-ledger mbertin-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍
Could you add some doc into README.md ? 🙏

@mbertin-ledger
Copy link
Member

👌 nice doc

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very very nice !
3d6b9e6deb174f6c38b27f6b41b7075d

Copy link
Contributor

@jdabbech-ledger jdabbech-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valpinkman valpinkman merged commit b4dd599 into develop Feb 1, 2024
4 checks passed
@valpinkman valpinkman deleted the feature/dsdk-185-scaffolding-tools branch February 13, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants