⚙️ (jfrog): Add postpack step

LedgerHQ · Sep 24, 2024 · d02f1ad · d02f1ad
1 parent cc1b6e9
commit d02f1ad
Show file tree

Hide file tree

Showing 8 changed files with 18 additions and 35 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -1,8 +1,9 @@
 name: publish npm packages
 on:
-  push:
-    branches:
-      - main
+  pull_request:
+  # push:
+  #   branches:
+  #     - main
 
 env:
   FORCE_COLOR: "1"
@@ -17,18 +18,18 @@ permissions:
 
 jobs:
   publish:
-    environment: Production
+    # environment: Production
     runs-on: ledgerhq-shared-medium
     steps:
       - uses: actions/checkout@v4
 
       - uses: ./.github/actions/setup-toolchain-composite
 
-      - name: install dependencies
-        run: pnpm install
+      # - name: install dependencies
+      #   run: pnpm install
 
-      - name: build libraries
-        run: pnpm build
+      # - name: build libraries
+      #   run: pnpm build
 
       - name: Login to internal JFrog registry
         id: jfrog-login
@@ -48,35 +49,11 @@ jobs:
         uses: changesets/action@v1
         with:
           publish: pnpm release
+          branch: fix/no-issue-jfrog-attest-sign-package
+          createGithubReleases: false
         env:
           GITHUB_TOKEN: ${{ secrets.CI_BOT_TOKEN }}
 
-      - name: Download published packages to attest and sign
-        if: steps.changesets.outputs.published == 'true'
-        env:
-          PUBLISHED_PACKAGE_JSON: published-packages.json
-        run: |
-          # Extract packages name
-          # output will be in the form of: [{"name":"@ledgerhq/package-name","version":"X.X.X"}]
-          cat << EOF | tee $PUBLISHED_PACKAGE_JSON
-          ${{ steps.changesets.outputs.publishedPackages }}
-          EOF
-
-          # Create dist directory
-          mkdir -p dist
-
-          # Loop over package names and download the tarball into dist directory
-          for row in $(cat $PUBLISHED_PACKAGE_JSON | jq -r '.[] | @text'); do
-            PACKAGE_NAME=$(echo $row| jq -r '.name')
-            PACKAGE_VERSION=$(echo $row | jq -r '.version')
-            PACKAGE_NAME_BASENAME=$(basename ${PACKAGE_NAME})
-
-            echo -e "\033[0;32mDownload artifact from\033[0m https://${NPM_REGISTRY}/${PACKAGE_NAME}/-/${PACKAGE_NAME}-${PACKAGE_VERSION}.tgz"
-            curl -H "Authorization: Bearer ${{ steps.jfrog-login.outputs.oidc-token }}" \
-              -o dist/${PACKAGE_NAME_BASENAME}-${PACKAGE_VERSION}.tgz \
-              https://${NPM_REGISTRY}/${PACKAGE_NAME}/-/${PACKAGE_NAME}-${PACKAGE_VERSION}.tgz
-          done
-
       - name: Attest tarball
         if: steps.changesets.outputs.published == 'true'
         uses: LedgerHQ/actions-security/actions/attest@actions/attest-1

diff --git a/package.json b/package.json
@@ -22,7 +22,7 @@
     "ui": "pnpm --filter @ledgerhq/device-sdk-ui",
     "sample": "pnpm --filter @ledgerhq/device-sdk-sample",
     "bump": "changeset version",
-    "release": "changeset publish",
+    "release": "pnpm recursive exec -- pnpm pack && changeset publish",
     "changelog": "changeset add",
     "commit": "gitmoji -c",
     "commitcl": "pnpm changelog && git add .changeset && pnpm commit",

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -32,6 +32,7 @@
     "dev:cjs": "concurrently \"tsc --watch -p tsconfig.cjs.json\" \"tsc-alias --watch -p tsconfig.cjs.json\"",
     "lint": "eslint",
     "lint:fix": "pnpm lint --fix",
+    "postpack": "find . -name '*.tgz' -exec mv ../../dist/ \\; 2> /dev/null",
     "prettier": "prettier . --check",
     "prettier:fix": "prettier . --write",
     "test": "jest",

diff --git a/packages/signer/context-module/package.json b/packages/signer/context-module/package.json
@@ -33,6 +33,7 @@
     "dev:cjs": "concurrently \"tsc --watch -p tsconfig.cjs.json\" \"tsc-alias --watch -p tsconfig.cjs.json\"",
     "lint": "eslint",
     "lint:fix": "pnpm lint --fix",
+    "postpack": "find . -name '*.tgz' -exec mv ../../../dist/ \\; 2> /dev/null",
     "prettier": "prettier . --check",
     "prettier:fix": "prettier . --write",
     "test": "jest",

diff --git a/packages/signer/keyring-btc/package.json b/packages/signer/keyring-btc/package.json
@@ -35,6 +35,7 @@
     "dev:cjs": "concurrently \"tsc --watch -p tsconfig.cjs.json\" \"tsc-alias --watch -p tsconfig.cjs.json\"",
     "lint": "eslint",
     "lint:fix": "pnpm lint --fix",
+    "postpack": "find . -name '*.tgz' -exec mv ../../../dist/ \\; 2> /dev/null",
     "prettier": "prettier . --check",
     "prettier:fix": "prettier . --write",
     "typecheck": "tsc --noEmit",

diff --git a/packages/signer/keyring-eth/package.json b/packages/signer/keyring-eth/package.json
@@ -35,6 +35,7 @@
     "dev:cjs": "concurrently \"tsc --watch -p tsconfig.cjs.json\" \"tsc-alias --watch -p tsconfig.cjs.json\"",
     "lint": "eslint",
     "lint:fix": "pnpm lint --fix",
+    "postpack": "find . -name '*.tgz' -exec mv ../../../dist/ \\; 2> /dev/null",
     "prettier": "prettier . --check",
     "prettier:fix": "prettier . --write",
     "typecheck": "tsc --noEmit",

diff --git a/packages/trusted-apps/package.json b/packages/trusted-apps/package.json
@@ -35,6 +35,7 @@
     "dev:cjs": "concurrently \"tsc --watch -p tsconfig.cjs.json\" \"tsc-alias --watch -p tsconfig.cjs.json\"",
     "lint": "eslint",
     "lint:fix": "pnpm lint --fix",
+    "postpack": "find . -name '*.tgz' -exec mv ../../dist/ \\; 2> /dev/null",
     "prettier": "prettier . --check",
     "prettier:fix": "prettier . --write",
     "typecheck": "tsc --noEmit",

diff --git a/packages/ui/package.json b/packages/ui/package.json
@@ -35,6 +35,7 @@
     "dev:cjs": "concurrently \"tsc --watch -p tsconfig.cjs.json\" \"tsc-alias --watch -p tsconfig.cjs.json\"",
     "lint": "eslint",
     "lint:fix": "pnpm lint --fix",
+    "postpack": "find . -name '*.tgz' -exec mv ../../dist/ \\; 2> /dev/null",
     "prettier": "prettier . --check",
     "prettier:fix": "prettier . --write",
     "typecheck": "tsc --noEmit",