chore(setup): review

.github/workflows/pull_request.yml

@@ -15,11 +15,8 @@ jobs:
 
       - uses: pnpm/action-setup@v2
         name: Install pnpm
-        with:
-          run_install: false
 
       - name: Get pnpm store directory
-        shell: bash
         run: |
           echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
 

.gitignore

@@ -19,6 +19,7 @@ node_modules
 
 # IDE
 .idea
+.vscode
 *.iml
 
 # misc
@@ -32,4 +33,4 @@ lib
 .turbo
 
 # eslint
-.eslintcache
+.eslintcache

package.json

@@ -12,18 +12,18 @@
     "dev": "turbo dev",
     "lint": "turbo run lint",
     "lint:fix": "turbo run lint:fix",
-    "core": "turbo --filter @ledgerhq/device-sdk-core",
-    "signer": "turbo --filter @ledgerhq/device-sdk-signer",
-    "trusted-apps": "turbo --filter @ledgerhq/device-sdk-trusted-apps",
-    "ui": "turbo --filter @ledgerhq/device-sdk-ui",
-    "sample": "turbo --filter @ledgerhq/device-sdk-sample",
+    "core": "pnpm --filter @ledgerhq/device-sdk-core",
+    "signer": "pnpm --filter @ledgerhq/device-sdk-signer",
+    "trusted-apps": "pnpm --filter @ledgerhq/device-sdk-trusted-apps",
+    "ui": "pnpm --filter @ledgerhq/device-sdk-ui",
+    "sample": "pnpm --filter @ledgerhq/device-sdk-sample",
     "test": "echo \"Error: no test specified\" && exit 1"
   },
   "devDependencies": {
     "@ledgerhq/eslint-config-dsdk": "workspace:*",
     "@ledgerhq/tsconfig-dsdk": "workspace:*",
     "lint-staged": "^15.2.0",
-    "path": "^0.12.7",
+    "prettier": "^3.1.1",
     "turbo": "^1.11.2",
     "eslint": "^8.56.0",
     "typescript": "^5.3.3",

packages/config/eslint/package.json

@@ -12,7 +12,6 @@
     "@vercel/style-guide": "^5.1.0",
     "eslint-config-prettier": "^9.1.0",
     "eslint-config-turbo": "^1.10.12",
-    "eslint-plugin-only-warn": "^1.1.0",
-    "prettier": "^3.1.1"
+    "eslint-plugin-only-warn": "^1.1.0"
   }
 }

packages/core/scripts/add-feature.mjs

@@ -1,6 +1,4 @@
 #!/usr/bin/env zx
-import { basename } from 'path';
-
 const features = argv._;
 
 if (!features.length) {

packages/core/src/transport/model/Response.ts

@@ -1,4 +1 @@
-
-export class Response {
-
-}
+export class Response {}

packages/core/src/transport/model/index.ts

@@ -1 +1 @@
-export { Response } from "./Response";
+export type { Response } from "./Response";