Fix ability cooldowns being triggered when GCD results in failure #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good changes :) They need RELEASES.md notes though :) Start a new heading for |
Updated RELEASES.md, thanks for the quick reply 😄! |
|
Awesome, thank you :) I think we should put together a small release shortly; message me if you have more that you'd like to squeeze in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51 and fixes #71, I believe #48 is already addressed as well with
CooldownState::setandChargeState::set, but maybe aninsertmethod would make it more clear, not too convinced either way.doctests were failing due to a Debug bound in ActionLike, popped those on.
The most significant changes are these
readyprior to triggering cooldowns, this is the fix for # 71OnGlobalCooldownerror for when an ability fails due to the GCD.readyso that an ability on cooldown returns anOnCooldownerror before anOnGlobalCooldownerror.I can remove
OnGlobalCooldownif its not a good addition, but I think it has merit for giving context on why an ability failed.