Upgrade to Bevy 0.15.0-dev. #644
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the work here was fallout from the gamepads-as-entities change (bevyengine/bevy#12770), as well as the `PartialReflect` changes. This relies on bevyengine/bevy#15685. That PR must be applied to Bevy for this to build. The most recent upstream commit is 4bf647ff3b0ca7c8ca47496db9cfe03702328473.
|
I think we can remove |
|
Yep, I pushed to get that upstreamed because it's really a @pcwalton I've merged the linked PR: please swap his to point to a pinned commit on |
s-puig
reviewed
Oct 8, 2024
| @@ -56,27 +64,27 @@ fn test_app() -> App { | |||
| #[ignore = "Broken upstream; tracked in https://github.com/Leafwing-Studios/leafwing-input-manager/issues/419"] | |||
| assert_eq!(events.drain().count(), 0); | ||
|
|
||
| let input = GamepadControlAxis::LEFT_X; | ||
| input.set_value(app.world_mut(), -1.0); | ||
|
|
||
| let mut events = app.world_mut().resource_mut::<Events<GamepadEvent>>(); | ||
| let mut events = app.world_mut().resource_mut::<Events<RawGamepadEvent>>(); | ||
| assert_eq!(events.drain().count(), 1); | ||
| } | ||
|
|
||
| #[test] | ||
| #[ignore = "Broken upstream; tracked in https://github.com/Leafwing-Studios/leafwing-input-manager/issues/419"] |
There was a problem hiding this comment.
Here too. I can't write but there should be one on line 303 that should also be fixed upstream.
|
I've updated to main. Tests are failing intermittently. I think it's a system ordering issue. Sometimes inputs are 1 frame behind. |
|
Will the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the work here was fallout from the gamepads-as-entities change (bevyengine/bevy#12770), as well as the
PartialReflectchanges.This relies on bevyengine/bevy#15685. That PR must be applied to Bevy for this to build.
The most recent upstream commit is
4bf647ff3b0ca7c8ca47496db9cfe03702328473.
I'm marking this as a draft because 0.15 isn't out yet.