Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wasm32 build to ci (#636) #637

Merged
merged 2 commits into from
Oct 6, 2024
Merged

Add wasm32 build to ci (#636) #637

merged 2 commits into from
Oct 6, 2024

Conversation

gak
Copy link
Contributor

@gak gak commented Sep 27, 2024 •
edited
Loading

Fixes #599 #636

@alice-i-cecile alice-i-cecile enabled auto-merge (squash) September 27, 2024 23:30
auto-merge was automatically disabled September 27, 2024 23:32

Head branch was pushed to by a user without write access

@gak gak marked this pull request as draft September 27, 2024 23:39
@alice-i-cecile
Copy link
Contributor

Thanks :) Let's see how this goes.

@gak gak force-pushed the ci-wasm branch 7 times, most recently from ad3303c to ec0fe42 Compare September 28, 2024 02:00
@gak
Copy link
Contributor Author

gak commented Sep 28, 2024 •
edited
Loading

Yaks shaved so far:

  • Had to update to bevy_egui 0.29 because of a wasm32 build error
  • 0.29 adds the bevy_winit feature which needs a rendering back-end to compile with, so I added the bevy/wayland feature when including egui when running ci.

@gak
Add wasm32 build to ci (Leafwing-Studios#636), bevy_egui -> 0.29
2dfd76d 
* Fixes a wasm build problem with bevy_egui too!
@gak gak marked this pull request as ready for review September 28, 2024 03:02
@gak
Copy link
Contributor Author

gak commented Sep 28, 2024

Finally! This took way too long. Hope it's acceptable.

@alice-i-cecile alice-i-cecile added build system Automatic testing breaking-change A breaking change that requires a new major version labels Sep 28, 2024
@alice-i-cecile
Copy link
Contributor

Awesome, thanks. Waiting for a bit due to being a breaking change with the dependency bump.

@alice-i-cecile alice-i-cecile enabled auto-merge (squash) October 6, 2024 15:59
@alice-i-cecile alice-i-cecile merged commit d6ef9e1 into Leafwing-Studios:main Oct 6, 2024
4 checks passed
@Shute052 Shute052 mentioned this pull request Oct 9, 2024
Merged
@alice-i-cecile alice-i-cecile mentioned this pull request Oct 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
breaking-change A breaking change that requires a new major version build system Automatic testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gak @alice-i-cecile