Change resolution check to use the primary monitor's working area. #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes oversized windows on multiple monitor setups when using dpi scaling.
|
I don't have multiple monitors, so I'll only need you to use "Pascal Case" in the variables (PowerShell style convention) and you're good to go. Thanks for fixing this mess :p |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Write-Verbose "Num. of Monitors: $NumberOfScreens" | ||
| # Get the primary screen's working area, which takes DPI scaling into account | ||
| $primaryScreen = [System.Windows.Forms.Screen]::PrimaryScreen | ||
| $bounds = $primaryScreen.Bounds |
Check warning
Code scanning / PSScriptAnalyzer
The variable 'bounds' is assigned but never used. Warning
|
As it's going to develop branch, I'll change it and merge to main, I did a mistake breaking another feature and need this PR to get inside too. |
Merged
LeDragoX
added a commit
that referenced
this pull request
May 28, 2024
* Removing all the properties changed to **Enable-WindowsSpotlight** - Fix Remove-ItemPropertyVerified * Add warning when path was not found using Remove-ItemPropertyVerified * Fixed `Remove-ItemPropertyVerified` inaccurately reporting success - The property is now removed correctly, accepting more paths * Change resolution check to use the primary monitor's working area. (#168) Fixes oversized windows on multiple monitor setups when using dpi scaling. * Use Pascal Casing inside Get-CurrentResolution.psm1 - Remove unused variable $bounds --------- Co-authored-by: Haxy <[email protected]>
LeDragoX
added a commit
that referenced
this pull request
Sep 8, 2024
* Removing all the properties changed to **Enable-WindowsSpotlight** - Fix Remove-ItemPropertyVerified * Add warning when path was not found using Remove-ItemPropertyVerified * Fixed `Remove-ItemPropertyVerified` inaccurately reporting success - The property is now removed correctly, accepting more paths * Change resolution check to use the primary monitor's working area. (#168) Fixes oversized windows on multiple monitor setups when using dpi scaling. * Use Pascal Casing inside Get-CurrentResolution.psm1 - Remove unused variable $bounds * Fix ArchWSL cert install - No manual steps required * Fix GPG signing key when a key already exists for git config * Stop logging before using the GPG/SSH setup * Fix Java EclipseAdoptium JDK installation * Remove Outlook app * fix: revert Stand by time when plugged in to 30 minutes * docs: Add section to import all modules in the terminal * refactor: Remove unneeded Windows Optional Features (#180) - NET Framework 3.5 - NET Framework 4.x + ASPNET 4.x * docs: Prepare to use main branch only - Set the Architecture as a requirement --------- Co-authored-by: Haxy <[email protected]>
LeDragoX
added a commit
that referenced
this pull request
Sep 8, 2024
* Change resolution check to use the primary monitor's working area. (#168) Fixes oversized windows on multiple monitor setups when using dpi scaling. * Use Pascal Casing inside Get-CurrentResolution.psm1 - Remove unused variable $bounds * Fix ArchWSL cert install - No manual steps required * Fix GPG signing key when a key already exists for git config * Stop logging before using the GPG/SSH setup * Fix Java EclipseAdoptium JDK installation * Remove Outlook app * fix: revert Stand by time when plugged in to 30 minutes * docs: Add section to import all modules in the terminal * refactor: Remove unneeded Windows Optional Features (#180) - NET Framework 3.5 - NET Framework 4.x + ASPNET 4.x * docs: Prepare to use main branch only - Set the Architecture as a requirement --------- Co-authored-by: Haxy <[email protected]>
LeDragoX
added a commit
that referenced
this pull request
Sep 8, 2024
* Removing all the properties changed to **Enable-WindowsSpotlight** - Fix Remove-ItemPropertyVerified * Add warning when path was not found using Remove-ItemPropertyVerified * Fixed `Remove-ItemPropertyVerified` inaccurately reporting success - The property is now removed correctly, accepting more paths * Change resolution check to use the primary monitor's working area. (#168) Fixes oversized windows on multiple monitor setups when using dpi scaling. * Use Pascal Casing inside Get-CurrentResolution.psm1 - Remove unused variable $bounds --------- Co-authored-by: Haxy <[email protected]>
LeDragoX
added a commit
that referenced
this pull request
Sep 8, 2024
* Change resolution check to use the primary monitor's working area. (#168) Fixes oversized windows on multiple monitor setups when using dpi scaling. * Use Pascal Casing inside Get-CurrentResolution.psm1 - Remove unused variable $bounds * Fix ArchWSL cert install - No manual steps required * Fix GPG signing key when a key already exists for git config * Stop logging before using the GPG/SSH setup * Fix Java EclipseAdoptium JDK installation * Remove Outlook app * fix: revert Stand by time when plugged in to 30 minutes * docs: Add section to import all modules in the terminal * refactor: Remove unneeded Windows Optional Features (#180) - NET Framework 3.5 - NET Framework 4.x + ASPNET 4.x * docs: Prepare to use main branch only - Set the Architecture as a requirement --------- Co-authored-by: Haxy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes oversized windows on multiple monitor setups when using dpi scaling.