Skip to content

use pam_sys of pam_client2 #42

use pam_sys of pam_client2

use pam_sys of pam_client2 #42

GitHub Actions / clippy succeeded Oct 20, 2024 in 0s

clippy

4 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 4
Note 0
Help 0

Versions

  • rustc 1.82.0 (f6e511eec 2024-10-15)
  • cargo 1.82.0 (8f40fc59f 2024-08-21)
  • clippy 0.1.82 (f6e511e 2024-10-15)

Annotations

Check warning on line 706 in rar-common/src/database/finder.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> rar-common/src/database/finder.rs:706:91
    |
706 |                     let min = PluginManager::notify_user_matcher(&as_borrow!(self), user, &element);
    |                                                                                           ^^^^^^^^ help: change this to: `element`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 491 in rar-common/src/database/finder.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> rar-common/src/database/finder.rs:491:47
    |
491 |             SGroups::Single(group) => is_root(&group),
    |                                               ^^^^^^ help: change this to: `group`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 326 in rar-common/src/database/finder.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

writing `&String` instead of `&str` involves a new object where a slice will do

warning: writing `&String` instead of `&str` involves a new object where a slice will do
   --> rar-common/src/database/finder.rs:326:27
    |
326 | fn match_path(input_path: &String, role_path: &String) -> CmdMin {
    |                           ^^^^^^^ help: change this to: `&str`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
    = note: `#[warn(clippy::ptr_arg)]` on by default

Check warning on line 258 in rar-common/src/util.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `tool`

warning: unused variable: `tool`
   --> rar-common/src/util.rs:258:17
    |
258 | pub fn subsribe(tool: &str) -> Result<(), Box<dyn Error>> {
    |                 ^^^^ help: if this is intentional, prefix it with an underscore: `_tool`
    |
    = note: `#[warn(unused_variables)]` on by default