Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type on Size #31

Closed
wants to merge 1 commit into from
Closed

Conversation

deanshelton
Copy link

@deanshelton deanshelton commented Sep 4, 2024

As shown in the turnstile docs here, the values for size do not include invisible. I presume that this was a mistake, and meant to be "flexible"

As shown in the turnstile docs [here](https://developers.cloudflare.com/turnstile/get-started/client-side-rendering/#appearance-modes), the values for size, do not include invisible. I presume that this was a mistake, and meant to be "flexible"
Copy link
Owner

@Le0Developer Le0Developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"invisible" is correct. It may not be documented, but its accepted and mainly for recaptcha compatibility.
Back in the day (almost 2 years ago now, time flies) it actually made the widget invisible too, but that functionality has since been removed.

@@ -220,7 +220,7 @@ export interface TurnstileProps extends TurnstileCallbacks {
tabIndex?: number;
responseField?: boolean;
responseFieldName?: string;
size?: "normal" | "invisible" | "compact";
size?: "normal" | "flexible" | "compact";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
size?: "normal" | "flexible" | "compact";
size?: "normal" | "invisible" | "compact" | "flexible";

@Le0Developer
Copy link
Owner

Le0Developer commented Sep 24, 2024

obsoleted by #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants