Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change sitekey prop to match camel case #21

Closed
wants to merge 1 commit into from
Closed

Change sitekey prop to match camel case #21

wants to merge 1 commit into from

Conversation

dev-bun
Copy link

@dev-bun dev-bun commented Jan 19, 2024

Not a major issue, I just believe that all props should match the same text case.

Copy link
Owner

@Le0Developer Le0Developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sitekey (all lowercase) is pretty standard across the ecosystem.

Imo this would only add confusion, as turnstile is using kebab-case, so people could think that siteKey maps to site-key (which it doesn't).
Also just a useless breaking change.

@@ -109,7 +109,7 @@ export default function Turnstile({
if (cancelled || !ref.current) return;
let boundTurnstileObject: BoundTurnstileObject;
const turnstileOptions: TurnstileOptions = {
sitekey,
siteKey,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turnstile is using sitekey, so this is setting the wrong key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants