-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: utilize split in existing rewards calculation #117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one clarification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good. main comment that needs addressing is on the floating point math around token calculations and if we should even modify the logic for past forks since they're only ever used when backfilling
d47aef9
to
5ebadaf
Compare
f5ce3ef
to
9f16817
Compare
The merge-base changed after approval.
eb636fa
to
883e248
Compare
9f16817
to
f4572a6
Compare
Utilize the `OperatorAVSSplit` and `OperatorPISplit` in the existing rewards v1 and Programmatic incentives calculation (instead of the hardcoded 10% split).
Utilize the `OperatorAVSSplit` and `OperatorPISplit` in the existing rewards v1 and Programmatic incentives calculation (instead of the hardcoded 10% split).
Utilize the `OperatorAVSSplit` and `OperatorPISplit` in the existing rewards v1 and Programmatic incentives calculation (instead of the hardcoded 10% split).
Utilize the `OperatorAVSSplit` and `OperatorPISplit` in the existing rewards v1 and Programmatic incentives calculation (instead of the hardcoded 10% split).
Utilize the `OperatorAVSSplit` and `OperatorPISplit` in the existing rewards v1 and Programmatic incentives calculation (instead of the hardcoded 10% split).
Utilize the `OperatorAVSSplit` and `OperatorPISplit` in the existing rewards v1 and Programmatic incentives calculation (instead of the hardcoded 10% split).
Utilize the `OperatorAVSSplit` and `OperatorPISplit` in the existing rewards v1 and Programmatic incentives calculation (instead of the hardcoded 10% split).
Utilize the
OperatorAVSSplit
andOperatorPISplit
in the existing rewards v1 and Programmatic incentives calculation (instead of the hardcoded 10% split).