Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: utilize split in existing rewards calculation #117

Merged
merged 15 commits into from
Dec 2, 2024

Conversation

0xrajath
Copy link

Utilize the OperatorAVSSplit and OperatorPISplit in the existing rewards v1 and Programmatic incentives calculation (instead of the hardcoded 10% split).

@0xrajath 0xrajath added the enhancement New feature or request label Nov 22, 2024
@0xrajath 0xrajath self-assigned this Nov 22, 2024
@0xrajath 0xrajath marked this pull request as ready for review November 23, 2024 00:11
@0xrajath 0xrajath requested a review from a team as a code owner November 23, 2024 00:11
@0xrajath 0xrajath requested a review from seanmcgary November 23, 2024 00:11
Copy link

@ypatil12 ypatil12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one clarification

pkg/rewards/2_goldStakerRewardAmounts.go Outdated Show resolved Hide resolved
pkg/rewards/5_goldRfaeStakers.go Outdated Show resolved Hide resolved
Copy link
Member

@seanmcgary seanmcgary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good. main comment that needs addressing is on the floating point math around token calculations and if we should even modify the logic for past forks since they're only ever used when backfilling

@0xrajath 0xrajath force-pushed the rajath/rewards-calculation branch from f5ce3ef to 9f16817 Compare December 1, 2024 22:48
ypatil12
ypatil12 previously approved these changes Dec 2, 2024
@seanmcgary seanmcgary dismissed ypatil12’s stale review December 2, 2024 14:54

The merge-base changed after approval.

@seanmcgary seanmcgary force-pushed the release/rewards-v2 branch 2 times, most recently from eb636fa to 883e248 Compare December 2, 2024 15:12
@0xrajath 0xrajath force-pushed the rajath/rewards-calculation branch from 9f16817 to f4572a6 Compare December 2, 2024 15:25
@0xrajath 0xrajath merged commit d845aca into release/rewards-v2 Dec 2, 2024
6 checks passed
@0xrajath 0xrajath deleted the rajath/rewards-calculation branch December 2, 2024 19:18
seanmcgary pushed a commit that referenced this pull request Dec 3, 2024
Utilize the `OperatorAVSSplit` and `OperatorPISplit` in the existing
rewards v1 and Programmatic incentives calculation (instead of the
hardcoded 10% split).
seanmcgary pushed a commit that referenced this pull request Dec 5, 2024
Utilize the `OperatorAVSSplit` and `OperatorPISplit` in the existing
rewards v1 and Programmatic incentives calculation (instead of the
hardcoded 10% split).
seanmcgary pushed a commit that referenced this pull request Dec 6, 2024
Utilize the `OperatorAVSSplit` and `OperatorPISplit` in the existing
rewards v1 and Programmatic incentives calculation (instead of the
hardcoded 10% split).
seanmcgary pushed a commit that referenced this pull request Dec 11, 2024
Utilize the `OperatorAVSSplit` and `OperatorPISplit` in the existing
rewards v1 and Programmatic incentives calculation (instead of the
hardcoded 10% split).
seanmcgary pushed a commit that referenced this pull request Dec 12, 2024
Utilize the `OperatorAVSSplit` and `OperatorPISplit` in the existing
rewards v1 and Programmatic incentives calculation (instead of the
hardcoded 10% split).
seanmcgary pushed a commit that referenced this pull request Dec 12, 2024
Utilize the `OperatorAVSSplit` and `OperatorPISplit` in the existing
rewards v1 and Programmatic incentives calculation (instead of the
hardcoded 10% split).
seanmcgary pushed a commit that referenced this pull request Dec 12, 2024
Utilize the `OperatorAVSSplit` and `OperatorPISplit` in the existing
rewards v1 and Programmatic incentives calculation (instead of the
hardcoded 10% split).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants