Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve the accordion transition #299

Merged
merged 2 commits into from
Apr 25, 2024
Merged

fix: improve the accordion transition #299

merged 2 commits into from
Apr 25, 2024

Conversation

teoh4770
Copy link
Contributor

Issue: #269

What has changed?

  • define the transition for grid-template-row instead of height

Note: let me know if the transition is still need to improve

Screen.Recording.Apr.24.mov

@teoh4770 teoh4770 added bug Something isn't working style labels Apr 24, 2024
@teoh4770 teoh4770 self-assigned this Apr 24, 2024
@teoh4770 teoh4770 linked an issue Apr 24, 2024 that may be closed by this pull request
[Bug] Laggy FAQ Accordion #269
Closed
@aidantrabs aidantrabs merged commit 504e577 into main Apr 25, 2024
2 checks passed
@aidantrabs aidantrabs deleted the bug/269/laggy-faq-accordion branch June 3, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juancwu juancwu Awaiting requested review from juancwu juancwu is a code owner

@aidantrabs aidantrabs Awaiting requested review from aidantrabs aidantrabs is a code owner

@SherRao SherRao Awaiting requested review from SherRao SherRao is a code owner

Assignees

@teoh4770 teoh4770

Labels
bug Something isn't working style
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Laggy FAQ Accordion
2 participants
@teoh4770 @aidantrabs