Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: anchor for meet the team has fixed #293

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

teoh4770
Copy link
Contributor

Issue: #292
Branch: fix/292/anchor-for-meet-the-team-is-way-too-high-up

  • fix 1: placing an extra div as an anchor instead of relying on the banner height, which is not reliable
  • fix 2: since there's potential overlay of team section with faq at tablet view, I have remove the style of it to keep them separate in tablet view only

- fix 1: placing an extra div as an anchor instead of relying on the banner height, which is not reliable
- fix 2: since there's potential overlay of team section with faq at tablet view, I have remove the style of it to keep them separate in tablet view only
@teoh4770 teoh4770 added bug Something isn't working style labels Apr 15, 2024
@teoh4770 teoh4770 self-assigned this Apr 15, 2024
@teoh4770 teoh4770 linked an issue Apr 15, 2024 that may be closed by this pull request
@aidantrabs aidantrabs merged commit 5f212a1 into main Apr 15, 2024
3 checks passed
@aidantrabs aidantrabs deleted the fix/292/anchor-for-meet-the-team-is-way-too-high-up branch June 3, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix] Anchor for Meet the Team is WAY too high up
2 participants