Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/280/fix faq section issues #284

Merged
merged 10 commits into from
Apr 13, 2024
Merged

Conversation

GabeDiniz
Copy link
Contributor

@GabeDiniz GabeDiniz commented Apr 10, 2024

✨ Issue: #280
πŸ”€ Branch: bug/280/fix faq section issues

✏ What was changed?

  • Updated all FAQs to match Notion
  • Decreased spacing for paragraphs in FAQ

πŸ“œ Things to know
@SherRao the "I'm lost!..." answer, in the notion you have an embedded link for the Google Map directions. I couldn't find an easy way to do this. I was able to do it in a sketchy way using dangerouslySetInnerHTML={{ __html: line }} and some conditionals inside fo the accordion.

For now, I just removed the line that says "Google Map directions can be found here".

@GabeDiniz GabeDiniz added the bug Something isn't working label Apr 10, 2024
@GabeDiniz GabeDiniz self-assigned this Apr 10, 2024
@GabeDiniz GabeDiniz linked an issue Apr 10, 2024 that may be closed by this pull request
6 tasks
Copy link
Contributor

@SherRao SherRao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not have tags inside of the paragraphs? there's a few hyperlinks we should have

@GabeDiniz
Copy link
Contributor Author

Can we not have tags inside of the paragraphs? there's a few hyperlinks we should have

@SherRao no :( it gets read as text unfortunately. I tried searching it up and all I found was the dangerouslySetInnerHTML={{ __html: line }} solution. Given the name, pretty sure its not a good idea XD

@teoh4770
Copy link
Contributor

teoh4770 commented Apr 10, 2024

I agree with @SherRao regarding the tags, personally feel that links should appear in the faq though :))
Also, you can try to increase the line-height slightly (around 1.4 - 1.6) since there are a lot of texts.

@SherRao
Copy link
Contributor

SherRao commented Apr 11, 2024

Can we not have tags inside of the paragraphs? there's a few hyperlinks we should have

@SherRao no :( it gets read as text unfortunately. I tried searching it up and all I found was the dangerouslySetInnerHTML={{ __html: line }} solution. Given the name, pretty sure its not a good idea XD

I give you my blessing and permission to use dangerouslySetInnerHTML, since this is a very valid use case.

@GabeDiniz
Copy link
Contributor Author

@SherRao it's not pretty bro.. but it works.

Copy link
Contributor

@SherRao SherRao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we hyperlink the two Discord channels mentioned, and hyperlink the contact email using mailto?

@aidantrabs aidantrabs merged commit 986f9c8 into main Apr 13, 2024
3 checks passed
@aidantrabs aidantrabs deleted the bug/280/fix-faq-section-issues branch June 3, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix FAQ section issues
4 participants