Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: improve performance #278

Merged
merged 6 commits into from
Apr 14, 2024
Merged

Fix: improve performance #278

merged 6 commits into from
Apr 14, 2024

Conversation

teoh4770
Copy link
Contributor

@teoh4770 teoh4770 commented Apr 9, 2024

Issue: #264
Branch: fix/264/performance-issue

What this pr do:
fix: accessibility score improve from 80 to 96
fix: clean up unused assets
fix: minimize a few images + preload some important images + lazy loa…

Note1: I have only slightly optimize some of the assets and indicate the browser to preload and lazy load some of the resources.
Note2: I realize there's a layout shift in the landing page, which i gonna fix first

@teoh4770 teoh4770 added the bug Something isn't working label Apr 9, 2024
@teoh4770 teoh4770 self-assigned this Apr 9, 2024
@teoh4770 teoh4770 linked an issue Apr 9, 2024 that may be closed by this pull request
@teoh4770 teoh4770 requested review from AmirAgassi and GabeDiniz April 9, 2024 22:00
Copy link
Contributor

@GabeDiniz GabeDiniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W Chee, we really needed this clean up

@aidantrabs
Copy link
Member

Fix merge conflicts and then you should be good to go

@teoh4770
Copy link
Contributor Author

Yup will do it 👍

The property '#/updates/0/package-ecosystem' value "pnpm" did not match one of the following values: npm, bundler, composer, devcontainers, maven, mix, cargo, gradle, nuget, gomod, docker, elm, gitsubmodule, github-actions, pip, terraform, pub, swift
@teoh4770
Copy link
Contributor Author

I got an error in the dependabot.yml file.
- package-ecosystem: "pnpm" #
I update this line to
- package-ecosystem: "npm" #
c3ad895

@teoh4770
Copy link
Contributor Author

@aidantrabs merge conflict is clear now

@aidantrabs aidantrabs merged commit 18b1550 into main Apr 14, 2024
4 checks passed
@aidantrabs aidantrabs deleted the fix/264/performance-issue branch June 3, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement] performance issue
3 participants