Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: edit dates in stats section #199

Merged
merged 3 commits into from
Mar 30, 2024
Merged

Fix: edit dates in stats section #199

merged 3 commits into from
Mar 30, 2024

Conversation

teoh4770
Copy link
Contributor

Issue: #197

  • I update the image that contains the wrong date in desktop view
  • I update the correct date(text) in mobile view

Note: let me know if the background should be larger like the previous one

@teoh4770 teoh4770 added the bug Something isn't working label Mar 30, 2024
@teoh4770 teoh4770 self-assigned this Mar 30, 2024
@teoh4770 teoh4770 linked an issue Mar 30, 2024 that may be closed by this pull request
[Fix] Edit dates in stats #197
Closed
juancwu
juancwu reviewed Mar 30, 2024
View reviewed changes
src/assets/hero-about/hero-about-desktop.svg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The height is diff, just want to make sure that this is not causing any issues.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is not causing any issue, but let me double check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me try to import the larger one to see the difference

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmk if all is good after testing and ill merge

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the larger one is better...let me change it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@teoh4770 teoh4770 requested a review from juancwu March 30, 2024 15:29
@juancwu juancwu merged commit 99b5124 into main Mar 30, 2024
3 checks passed
@juancwu juancwu deleted the fix/197/edit-dates-in-stats branch March 30, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabeDiniz GabeDiniz GabeDiniz approved these changes

@juancwu juancwu juancwu approved these changes

@aidantrabs aidantrabs Awaiting requested review from aidantrabs aidantrabs is a code owner

@norachams norachams Awaiting requested review from norachams

@ABCodez ABCodez Awaiting requested review from ABCodez

Assignees

@teoh4770 teoh4770

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] Edit dates in stats
4 participants
@teoh4770 @aidantrabs @juancwu @GabeDiniz