Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure the navbar links are linking to the right places #191

Merged
merged 7 commits into from
Mar 29, 2024

Conversation

teoh4770
Copy link
Contributor

@teoh4770 teoh4770 commented Mar 29, 2024

Issue: #179

@teoh4770 teoh4770 added bug Something isn't working style labels Mar 29, 2024
@teoh4770 teoh4770 self-assigned this Mar 29, 2024
@teoh4770 teoh4770 linked an issue Mar 29, 2024 that may be closed by this pull request
@teoh4770 teoh4770 requested a review from juancwu March 29, 2024 19:48
@teoh4770 teoh4770 changed the title fix: make sure clicking the anchor tag actually works fix: make sure the navbar links are linking to the right places Mar 29, 2024
@aidantrabs
Copy link
Member

Can we make the about us anchor specifically be centred to the section, lots of extra space - think this would cleaner

That is:

  • Before:
    image

  • After:
    image

  • Before:
    image

  • After:
    image

@aidantrabs aidantrabs merged commit a241bb0 into main Mar 29, 2024
3 checks passed
@aidantrabs aidantrabs deleted the fix/179/fix-navbar-links branch June 3, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix navbar links
2 participants