Fix/154/sponsorship-section-style-improvement #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
womp womp
|
GabeDiniz
reviewed
Mar 29, 2024
There was a problem hiding this comment.
The bar scroll bar is a little wonky looking..
May I suggest, we could either change the styling of the scroll bar (https://www.geeksforgeeks.org/how-to-change-style-of-scrollbar-using-tailwind-css/)
OR make it so when there's overflow, its an animated carousel that infinitely goes through the sponsors? <-- this one might be a pain in the ass to do though
juancwu
approved these changes
Mar 30, 2024
| carousel.style.transform = `translateX(-${currentPosition}px)`; | ||
| animationFrameIds.set( | ||
| carousel, | ||
| requestAnimationFrame(updatePosition) |
There was a problem hiding this comment.
you know its real when you call requestAnimationFrame
There was a problem hiding this comment.
you know its real when you call
requestAnimationFrame
ong bro, 10x react dev right here
GabeDiniz
approved these changes
Mar 30, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
juancwu
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️[Fix] sponsorship section style improvement #154
🔍 What's Included
Sponsor.section.tsx.📁 Files Affected:
src/assets/logos/taskade.pngsrc/components/sections/Sponsor.section.tsx