Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: make horizontal padding align across the page #163

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Fix: make horizontal padding align across the page #163

merged 5 commits into from
Mar 27, 2024

Conversation

teoh4770
Copy link
Contributor

Issue: #162
Branch: fix/157/horizontal-padding-seems-not-align-in-every-section

Note:

  1. I have remove the styling in a part of the hero section, since I have another pr that's gonna merge a new styling to it
  2. I didn't change the sponsors, since it's gonna have a major change (will have horizontal scrollbars)

@teoh4770 teoh4770 added the style label Mar 27, 2024
@teoh4770 teoh4770 self-assigned this Mar 27, 2024
@teoh4770 teoh4770 linked an issue Mar 27, 2024 that may be closed by this pull request
[Fix] horizontal padding seems not align in every section #157
Closed
@teoh4770 teoh4770 requested a review from ABCodez March 27, 2024 01:28
@aidantrabs
Copy link
Member

  • 1500px width
Screenshot 2024-03-26 at 11 35 44 PM Screenshot 2024-03-26 at 11 36 17 PM

@teoh4770
Copy link
Contributor Author

@aidantrabs fixed. Ready for review

@aidantrabs
Copy link
Member

Fix conflicts and then merge

@teoh4770 teoh4770 merged commit fbdf19b into main Mar 27, 2024
3 checks passed
@aidantrabs aidantrabs deleted the fix/157/horizontal-padding-seems-not-align-in-every-section branch June 3, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabeDiniz GabeDiniz GabeDiniz approved these changes

@aidantrabs aidantrabs aidantrabs approved these changes

@ABCodez ABCodez Awaiting requested review from ABCodez

Assignees

@teoh4770 teoh4770

Labels
style
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] horizontal padding seems not align in every section
3 participants
@teoh4770 @aidantrabs @GabeDiniz