Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/145/about content on mobile #146

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

GabeDiniz
Copy link
Contributor

✨ Issue: #145
πŸ”€ Branch: feature/145/about-content-on-mobile

✏ What was changed?

  • Update SVG for mobile
  • Change text color to match Hero section (hopefully its more readable)

Let me know what you guys think about the text color. It matches the Hero section now and I think its a little more readable. I don't know how I feel about the About Title and Content being different colors though.

See the last screenshot to see the possible alternative for text-color.

πŸ“œ Screenshots
Width: 390px
image

Width: 650px
image

Possible alternative?
image

@GabeDiniz GabeDiniz added the enhancement New feature or request label Mar 24, 2024
@GabeDiniz GabeDiniz self-assigned this Mar 24, 2024
@GabeDiniz GabeDiniz requested a review from aidantrabs as a code owner March 24, 2024 16:58
@GabeDiniz
Copy link
Contributor Author

Looks better with the gradient:
image
image

Copy link
Contributor

@teoh4770 teoh4770 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got one question: Why do we have repeated images in the assets/hero-about?

Screenshot 2024-03-24 at 6 12 34β€―PM

@teoh4770
Copy link
Contributor

and I feel like the about section paragraphs' color can be darker to make the text more obvious.
I have run the color choices in the web accessibility color contrast checker, and it suggests that as well.

@teoh4770
Copy link
Contributor

Screenshot 2024-03-24 at 6 31 57β€―PM

I also find that the spacing of the content is weird in desktop view.
I know it is not under your scope of your pr, we can make an issue for that after we have addressed this one first.

@teoh4770
Copy link
Contributor

teoh4770 commented Mar 24, 2024

but besides that, I think @GabeDiniz changes make it better for sure!

@GabeDiniz
Copy link
Contributor Author

Got one question: Why do we have repeated images in the assets/hero-about?

Screenshot 2024-03-24 at 6 12 34β€―PM

I was gonna remove that :) just waiting to see if everyone was happy with the final design. I didn't want to get rid of it until we all came to an agreement on the styling. Sorry about that, I should've said said that πŸ˜…

@GabeDiniz
Copy link
Contributor Author

and I feel like the about section paragraphs' color can be darker to make the text more obvious. I have run the color choices in the web accessibility color contrast checker, and it suggests that as well.

@teoh4770 do you have a color suggestion? What do you think of this (#1D4549)
image

@GabeDiniz
Copy link
Contributor Author

GabeDiniz commented Mar 24, 2024

Screenshot 2024-03-24 at 6 31 57β€―PM

I also find that the spacing of the content is weird in desktop view. I know it is not under your scope of your pr, we can make an issue for that after we have addressed this one first.

@teoh4770, you are right, its totally weird LOL.. I just fixed it. Should look a lot better now for all breakpoints.

@teoh4770
Copy link
Contributor

and I feel like the about section paragraphs' color can be darker to make the text more obvious. I have run the color choices in the web accessibility color contrast checker, and it suggests that as well.

@teoh4770 do you have a color suggestion? What do you think of this (#1D4549)
image

As long as it's clear to see, and the colour is aligned with the title like the one you have. Others can suggest the colour as well

@teoh4770
Copy link
Contributor

teoh4770 commented Mar 25, 2024

Got one question: Why do we have repeated images in the assets/hero-about?

Screenshot 2024-03-24 at 6 12 34β€―PM

I was gonna remove that :) just waiting to see if everyone was happy with the final design. I didn't want to get rid of it until we all came to an agreement on the styling. Sorry about that, I should've said said that πŸ˜…

We can always revert back to the change if we want to get back the original picπŸ‘
And no worries though

@aidantrabs
Copy link
Member

We'll talk about this tonight

@aidantrabs aidantrabs merged commit c2ec4a7 into main Mar 26, 2024
3 checks passed
@aidantrabs aidantrabs deleted the feature/145/about-content-on-mobile branch June 3, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants