Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/94/create about section #119

Merged
merged 31 commits into from
Mar 8, 2024
Merged

Conversation

GabeDiniz
Copy link
Contributor

✨ Issue: #94
πŸ”€ Branch: feature/94/create-about-section

✏ What was changed?

  • Create About section with the SVG background
  • Add the Air Balloon animation

πŸ“œ Suggestions and things to know
The heading and text on the Figma design seem off.

  • The Heading is white but the text is black which doesn't seem to fit well. They contrast each other poorly
  • The Heading is also center aligned while the text is left aligned. Also looks odd.
  • For this PR I made both white and center aligned. Let me know what you guys think!!

The Navbar

  • I believe making the navbar sticky instead of fixed would work better (let me know what you guys think though). Sticky allows the next section to be placed underneath it, while fixed makes it so the navbar sits on top of the section. Which is why I added crazy top padding to the section.

@GabeDiniz GabeDiniz self-assigned this Feb 25, 2024
src/components/index.tsx Outdated Show resolved Hide resolved
src/pages/Landing.tsx Outdated Show resolved Hide resolved
src/components/sections/About.section.tsx Outdated Show resolved Hide resolved
src/components/sections/About.section.tsx Outdated Show resolved Hide resolved
src/components/sections/About.section.tsx Outdated Show resolved Hide resolved
@GabeDiniz
Copy link
Contributor Author

GabeDiniz commented Feb 27, 2024

βœ… [Feature] Move buildings to the side for Mobile view for more white space
βœ… [Feature] Remove Hawk Airballoon on mobile view
βœ… [Bug] SVG doesn't fit on large-width screen

@GabeDiniz
Copy link
Contributor Author

@aidantrabs could you check if the bug is still present on your screen? The one where the svg doesn't fit on your screen.

src/components/sections/About.section.tsx Outdated Show resolved Hide resolved
src/components/index.tsx Outdated Show resolved Hide resolved
src/pages/Landing.tsx Outdated Show resolved Hide resolved
@teoh4770 teoh4770 self-requested a review March 1, 2024 04:20
@juancwu
Copy link
Contributor

juancwu commented Mar 4, 2024

@aidantrabs could you check if the bug is still present on your screen? The one where the svg doesn't fit on your screen.

On my 2k monitor, the svg still does not expand the whole width.

Screenshot from 2024-03-03 23-05-25

@GabeDiniz GabeDiniz linked an issue Mar 4, 2024 that may be closed by this pull request
@juancwu juancwu added the enhancement New feature or request label Mar 8, 2024
@juancwu juancwu merged commit 1f46d80 into main Mar 8, 2024
3 checks passed
@juancwu juancwu deleted the feature/94/create-about-section branch March 8, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Create About section and styling
4 participants