Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: make hero section prototype #116

Merged
merged 14 commits into from
Mar 8, 2024

Conversation

teoh4770
Copy link
Contributor

Issue: #104
Branch: feature/104/make-hero-section-prototype

What is this pr do?

Setup hero section with the amazing background ✨

Concerns?

  1. I have turn background svg into react component for animation purposes, but I'm not sure if this is normally done like this (we could apply animation class on svg component directly in this way).
  2. Spacing issue, need a consistent spacing (padding around the section) across the page, not just individual one.

Things to implement in the future

  1. Animation on the little things 🚀 Any animation library suggestion?

@teoh4770 teoh4770 added the enhancement New feature or request label Feb 22, 2024
@teoh4770 teoh4770 self-assigned this Feb 22, 2024
@teoh4770 teoh4770 linked an issue Feb 22, 2024 that may be closed by this pull request
@juancwu
Copy link
Contributor

juancwu commented Feb 24, 2024

Can you resolves the conflicts?

@teoh4770
Copy link
Contributor Author

let me try

@teoh4770
Copy link
Contributor Author

@juancwu merge conflict is gone

Copy link
Contributor

@GabeDiniz GabeDiniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the Navbar is cutting off the top of the SVG
image

Not sure about this one but: in mobile view, the title/date looks odd. Might be easier to keep the date on the SVG (although it could appear too small there).
image

…to feature/104/make-hero-section-prototype
@teoh4770
Copy link
Contributor Author

We can discuss it at tomorrow meeting @GabeDiniz

@teoh4770 teoh4770 requested review from juancwu and GabeDiniz March 5, 2024 00:49
@juancwu
Copy link
Contributor

juancwu commented Mar 5, 2024

image

@teoh4770 Here are the updates for the hero section. Can you add the new things in this PR as well?

Basically, is a subtitle and everything has been moved up a little closer to the Navbar.

Feel free to take a look in Figma.

@teoh4770
Copy link
Contributor Author

teoh4770 commented Mar 5, 2024

I think it is ok now, can you check?

@teoh4770
Copy link
Contributor Author

teoh4770 commented Mar 5, 2024

Besides the font size is bad imo, the layout is ok for now.

Copy link
Contributor

@juancwu juancwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing we need to fix later is to keep the font sizes as close as possible to the figma design. The HawkHacks title and the subtitle now don't have big enough of a difference that makes it look weird.

@juancwu juancwu merged commit 6e6e323 into main Mar 8, 2024
3 checks passed
@juancwu juancwu deleted the feature/104/make-hero-section-prototype branch March 8, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Make Hero Section Prototype
3 participants