-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: make hero section prototype #116
Conversation
Can you resolves the conflicts? |
let me try |
@juancwu merge conflict is gone |
…hub.com/LaurierHawkHacks/Landing into feature/104/make-hero-section-prototype
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…to feature/104/make-hero-section-prototype
We can discuss it at tomorrow meeting @GabeDiniz |
@teoh4770 Here are the updates for the hero section. Can you add the new things in this PR as well? Basically, is a subtitle and everything has been moved up a little closer to the Navbar. Feel free to take a look in Figma. |
I think it is ok now, can you check? |
Besides the font size is bad imo, the layout is ok for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor thing we need to fix later is to keep the font sizes as close as possible to the figma design. The HawkHacks title and the subtitle now don't have big enough of a difference that makes it look weird.
Issue: #104
Branch: feature/104/make-hero-section-prototype
What is this pr do?
Setup hero section with the amazing background ✨
Concerns?
Things to implement in the future