Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/141/update-initiative-card-to-fit-figma-design #150

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

AmirAgassi
Copy link
Member

🎨 Update Initiative Card to Fit Figma Design #141

🔍 What's Included

  • Updated assets for down_arrow.svg, plant.svg, and adjustments in index.tsx for exporting these new assets.
  • Major refactoring and enhancements in PODS.tsx to match Figma design specifications, including UI adjustments and functionality improvements for better user experience.
  • Adjustments in ReviewSessions.tsx that look cool (optional).
  • Extensive updates to styles.ts to accommodate new design requirements.

📁 Files Affected:

  • src/assets/down_arrow.svg
  • src/assets/plant.svg
  • src/assets/index.tsx
  • src/components/InitiativesSection/initiatives/PODS.tsx
  • src/components/InitiativesSection/initiatives/ReviewSessions.tsx
  • src/components/InitiativesSection/initiatives/styles.ts

TODO

  • Make it responsive fr

@AmirAgassi AmirAgassi linked an issue Mar 11, 2024 that may be closed by this pull request
@AmirAgassi AmirAgassi self-assigned this Mar 11, 2024
@juancwu juancwu changed the base branch from main to dev March 11, 2024 21:03
@juancwu
Copy link
Collaborator

juancwu commented Mar 11, 2024

Change the base to dev since the component is not ready for production.

@juancwu
Copy link
Collaborator

juancwu commented Mar 11, 2024

@AmirAgassi can you run pnpm lint --fix to fix the eslint issue?

Copy link
Collaborator

@juancwu juancwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good aside from the failing eslint check.

@AmirAgassi
Copy link
Member Author

@AmirAgassi can you run pnpm lint --fix to fix the eslint issue?

Whoops, didn't notice the eslint error yesterday. I gave it a quick run with --fix and fixed the apostrophe, all good now 💯

@juancwu juancwu merged commit c2ff615 into dev Mar 11, 2024
@juancwu juancwu deleted the 141-feature-update-initiative-card-to-fit-figma-design branch March 11, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Update Initiative Card to Fit Figma Design
2 participants